[PATCH] D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:940
+        return false;
+
+      // TODO: Check if MT can be moved upwards.
----------------
We should dump MT or do something to test this.

Also, do we store MT somewhere? Otherwise we might be able to just use a object that cannot be copied.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:976
+    Value *SizesArg =
+        RuntimeCall.getArgOperand(OffloadArray::SizesArgNum);
 
----------------
Commit this part as NFC before this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86474/new/

https://reviews.llvm.org/D86474