[PATCH] D86487: [DSE,MemorySSA] Check if DomAccess is valid for elimination first.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/simple.ll:480
 
 ; TODO
 ; We can remove redundant store, as noalias %p guarantees that the function does
----------------
fhahn wrote:
> xbolva00 wrote:
> > Remove todo?
> Thanks, that looks indeed fixed now :)
Actually, the change was a problem and I think the TODO is invalid. I updated the comment to say we cannot remove `store i32 1...` because it may be read by the caller if unknown_func unwinds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86487/new/

https://reviews.llvm.org/D86487