[PATCH] D86449: [SelectionDAG] Handle non-power-of-2 bitwidths in expandROT

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Do we guarantee that the rotate amount is not undef? (Can we assert that?)
The expansion may fail if the rotate amount is 'undef':
https://alive2.llvm.org/ce/z/tqjuC7



================
Comment at: llvm/test/CodeGen/WebAssembly/fshl.ll:4
+
+target triple = "wasm32-unknown-unknown"
+
----------------
foad wrote:
> RKSimon wrote:
> > move the triple into the run command?
> Could do but why? That is definitely not the prevailing style in test/CodeGen/WebAssembly/.
This should be fine. Specifying the target in the IR is the default. 
Over in x86, we tend to prefer to put it on the RUN line because we have many tests that vary the subtarget slightly...because there are so many HW variations to think about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86449/new/

https://reviews.llvm.org/D86449