[PATCH] D86456: AMDGPU/GlobalISel: Use more accurate legality rules for merge/unmerge

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 06:16:31 PDT 2020


arsenm added a comment.

In D86456#2235961 <https://reviews.llvm.org/D86456#2235961>, @foad wrote:

>> Unfortunately, this means spreading the -global-isel-abort=0 hack
>
> What's the proper fix for this? Is there some (generic?) work to do on legalizing merge/unmerge?

Legalizing the artifacts is tricky because you end up producing the original operation to copy back to the original registers. The rules for legalize rules as written in the documentation I also think make no sense for vectors. D86458 <https://reviews.llvm.org/D86458> is my attempt at fixing this (although a few more parts may still need fixing)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86456/new/

https://reviews.llvm.org/D86456



More information about the llvm-commits mailing list