[PATCH] D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4)

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1569
+  // Test if the location terminates before the end of the scope.
+  const MachineInstr *LScopeEnd = LSRange.back().second;
   if (Ordering.isBefore(RangeEnd, LScopeEnd))
----------------
djtodoro wrote:
> What does this change specially perform with multi BBs?
This line specifically has just moved down from line 1544.

More generally, the previous patch in the series (D86151) introduced the `const InstructionOrdering &Ordering` parameter and used it on line 1590, replacing a scan through MBB instructions. The functionality to compare instruction positions across blocks was add there, and this patch just removes the exit checks that were previously (but no longer) required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86152/new/

https://reviews.llvm.org/D86152