[PATCH] D86281: [compiler-rt][builtins] Tweak checks for lock-free atomics

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 01:21:34 PDT 2020


arichardson added inline comments.


================
Comment at: compiler-rt/lib/builtins/atomic.c:124
+/// Macros for determining whether a size is lock free.
+#define IS_LOCK_FREE_1 __atomic_always_lock_free(1, NULL)
+#define IS_LOCK_FREE_2 __atomic_always_lock_free(2, NULL)
----------------
Actually, I'm not sure if passing NULL is correct, can `__atomic_load` be called with an under-aligned pointer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86281/new/

https://reviews.llvm.org/D86281



More information about the llvm-commits mailing list