[PATCH] D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/test/tools/not/disable-symbolization.test:1
+# RUN: not --crash env > %t || true
+# RUN: FileCheck %s < %t
----------------
zequanwu wrote:
> aganea wrote:
> > dblaikie wrote:
> > > MaskRay wrote:
> > > > aganea wrote:
> > > > > This test also fails on Windows - I think lit doesn't like `env` alone.
> > > > > 
> > > > > ```
> > > > > ******************** TEST 'LLVM :: tools/not/disable-symbolization.test' FAILED ********************
> > > > > Script:
> > > > > --
> > > > > : 'RUN: at line 1';   not --crash env > D:\llvm-project\buildninjaRel\test\tools\not\Output\disable-symbolization.test.tmp || true
> > > > > : 'RUN: at line 2';   d:\llvm-project\buildninjarel\bin\filecheck.exe D:\llvm-project\llvm\test\tools\not\disable-symbolization.test < D:\llvm-project\buildninjaRel\test\tools\not\Output\disable-symbolization.test.tmp
> > > > > --
> > > > > Exit Code: 127
> > > > > 
> > > > > Command Output (stdout):
> > > > > --
> > > > > $ ":" "RUN: at line 1"
> > > > > $ "not" "--crash" "env"
> > > > > # command stderr:
> > > > > Error: 'env' requires a subcommand
> > > > > error: command failed with exit status: 127
> > > > > 
> > > > > --
> > > > > ```
> > > > > 
> > > > > `printenv` instead?
> > > > Thanks! `printenv` is not specified by POSIX, so I did not use it. But I just checked: `printenv` appeared in 3.0BSD & Solaris has it as well, so the portability is good.
> > > Any ideas if this'll work on Windows?
> > @dblaikie It does work, since a Unix-like shell is required anyway to run the lit tests on Windows, either MinGW, CygWin or GnuWin32 on the top of the regular cmd shell.
> Hi, this test failed on Windows
> ```
> ******************** TEST 'LLVM :: tools/not/disable-symbolization.test' FAILED ********************
>  Script:
>  --
>  : 'RUN: at line 1';   not --crash printenv > C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\test\tools\not\Output\disable-symbolization.test.tmp || true
>  : 'RUN: at line 2';   c:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\bin\filecheck.exe C:\b\s\w\ir\cache\builder\src\third_party\llvm\llvm\test\tools\not\disable-symbolization.test < C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\test\tools\not\Output\disable-symbolization.test.tmp
>  --
>  Exit Code: 2
>  
>  Command Output (stdout):
>  --
>  $ ":" "RUN: at line 1"
>  $ "not" "--crash" "printenv"
>  # command stderr:
>  error: unable to find `printenv' in PATH: no such file or directory
> ```
@zequanwu Are you running from a cmd shell or a Unix-like shell? Do you have GnuWin32 installed and in PATH?

This is what I see from cmd.exe:
```
D:\llvm-project>which printenv
C:\Users\aganea\Downloads\GetGnuWin32\gnuwin32\bin\printenv.EXE
```
>From a MinGW shell:
```
$ which printenv
/usr/bin/printenv
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86170/new/

https://reviews.llvm.org/D86170