[PATCH] D85368: [llvm][CodeGen] Machine Function Splitter

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram accepted this revision.
tmsriram added a comment.

LGTM, thanks for doing this!



================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:109
+
+  MF.RenumberBlocks();
+  MF.setBBSectionsType(BasicBlockSection::Preset);
----------------
Maybe a comment here that this is useful while sorting the blocks?


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:117
+    // as part of the original function.
+    if ((MBB.pred_empty() || MBB.isEHPad()))
+      continue;
----------------
Do we need a fixme comment here to say that we could split out landing pads if the exception patch for bb sections lands?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85368/new/

https://reviews.llvm.org/D85368