[PATCH] D86485: [test] Fix FullUnroll.ll

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 13:48:01 PDT 2020


aeubanks created this revision.
aeubanks added reviewers: echristo, asbirlea, ychen.
Herald added subscribers: llvm-commits, zzheng.
Herald added a project: LLVM.
aeubanks requested review of this revision.

I believe the intention of this test added in
https://reviews.llvm.org/D71687 was to test LoopFullUnrollPass with
clang's -fno-unroll-loops, not its interaction with optnone. Loop
unrolling passes don't run under optnone/-O0.

Also added back unintentionally removed -disable-loop-unrolling from
https://reviews.llvm.org/D85578.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86485

Files:
  llvm/test/Transforms/LoopUnroll/FullUnroll.ll


Index: llvm/test/Transforms/LoopUnroll/FullUnroll.ll
===================================================================
--- llvm/test/Transforms/LoopUnroll/FullUnroll.ll
+++ llvm/test/Transforms/LoopUnroll/FullUnroll.ll
@@ -1,4 +1,4 @@
-; RUN: opt -passes='loop-unroll-full' -disable-verify --mtriple x86_64-pc-linux-gnu -S -o - %s | FileCheck %s
+; RUN: opt -passes='loop-unroll-full' -disable-verify -disable-loop-unrolling=true --mtriple x86_64-pc-linux-gnu -S -o - %s | FileCheck %s
 
 ; This checks that the loop full unroller will fire in the new pass manager
 ; when forced via #pragma in the source (or annotation in the code).
@@ -39,7 +39,7 @@
   ret void
 }
 
-attributes #0 = { noinline nounwind optnone uwtable }
+attributes #0 = { nounwind uwtable }
 
 !llvm.module.flags = !{!0}
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86485.287483.patch
Type: text/x-patch
Size: 797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200824/2bc51257/attachment.bin>


More information about the llvm-commits mailing list