[PATCH] D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 10:00:52 PDT 2020


lebedev.ri added a comment.

In D86262#2233995 <https://reviews.llvm.org/D86262#2233995>, @anhtuyen wrote:

> Hi  @lebedev.ri 
> I saw you had **//again//** requested changes to this revision, but I could **not** find what changes that you thought should be required. Can you please be specific?

I'd like to better understand the roadmap here.
Initially the patch was submitted as a bandaid for DA, but then it was, taken over?, by general performance concerns.

1. Is there or is there no a DA problem for these intrinsics?
  1. Is there a bugreport?
  2. Is there a testcase?
  3. If the patch proceeds as-is, what's long-term plan? Is anyone planning on addressing the underlying problem?
2. For the transform itself
  1. Is there a bugreport
  2. Is there a testcase? (i can see it in comments, but it should be in bugreport)
  3. Is anyone planning on fixing this in more long-term way, with costmodelling and whatnot?

In none of those cases is such a flag a reasonable long-term solution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86262/new/

https://reviews.llvm.org/D86262



More information about the llvm-commits mailing list