[PATCH] D86442: Skip analysis re-computation when no changes are reported

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/CallGraphSCCPass.cpp:478
     verifyPreservedAnalysis(P);
-    removeNotPreservedAnalysis(P);
+    if (Changed)
+      removeNotPreservedAnalysis(P);
----------------
This (and line 473) should probably test a "LocalChanged" flag which is ORed into Changed?


================
Comment at: llvm/lib/Analysis/RegionPass.cpp:123
 
-      removeNotPreservedAnalysis(P);
+      if (Changed)
+        removeNotPreservedAnalysis(P);
----------------
Use a LocalChanged flag here and line 101?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86442/new/

https://reviews.llvm.org/D86442