[PATCH] D85116: [compiler-rt][profile] Fix various InstrProf tests on Solaris

Mon Aug 24 02:51:55 PDT 2020

ro added a comment.

In D85116#2231692 <https://reviews.llvm.org/D85116#2231692>, @inferno wrote:

> We are seeing regressions on Linux, from this. See https://github.com/google/oss-fuzz/issues/4348. Can you please revert as it breaks coverage on several linux binaries.

Can do, however I'd first try if the issue can be fixed quickly instead of trading breakage on one platform for breakage on another.

First, how did you verify that this patch is the culprit?  While it seems plausible, I've seen too many cases where a likely candidate turned out to be innocent, wasting everyone's time.

Can you please also provide lots of additional information:

- Which platform are you seeing this error on?

- Which revision of `clang` were you using?  Any local changes?  How exactly was `cmake` invoked?

- Which linker do you use?

- Can you provide the output of `readelf -SW` for the binary that produces the error, the version of `libclang_rt.profile-*.a`linked, and if possible for the input objects that have `__llvm_prf_names` sections?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85116/new/

https://reviews.llvm.org/D85116