[PATCH] D86152: [DwarfDebug] Improve multi-BB single location detection in validThroughout (3/4)

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1569
+  // Test if the location terminates before the end of the scope.
+  const MachineInstr *LScopeEnd = LSRange.back().second;
   if (Ordering.isBefore(RangeEnd, LScopeEnd))
----------------
What does this change specially perform with multi BBs?


================
Comment at: llvm/test/DebugInfo/X86/location-range-inlined-xblock.mir:66
+
+  declare void @llvm.dbg.declare(metadata, metadata, metadata)
+  declare !dbg !41 dso_local i32 @_Z4ext1i(i32)
----------------
unused, please remove this


================
Comment at: llvm/test/DebugInfo/X86/location-range-inlined-xblock.mir:96
+  !20 = !{!"omnipotent char", !21, i64 0}
+  !21 = !{!"Simple C++ TBAA"}
+  !22 = !DILocation(line: 7, column: 15, scope: !23, inlinedAt: !29)
----------------
I guess we don't need tbaa metadata for this test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86152/new/

https://reviews.llvm.org/D86152