[PATCH] D85894: [BuildLibCalls] Add more noundef to library functions

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 00:39:48 PDT 2020


aqjune added a comment.

In D85894#2232884 <https://reviews.llvm.org/D85894#2232884>, @guiand wrote:

> LGTM, although I'm just curious about the omissions here. why not mark something like `round` noundef?

Thanks!

I think `round` can have noundef as well.
Calling `round` can set floating point exception (FE_INEXACT) if the result does not fit in the type, so `round` isn't expected to freely move around (e.g. hoist it out of a loop). So I don't think having noundef (which makes `round` raise UB in undef inputs) will block existing optimizations.

For noundefs for arithmetic functions, I'll make a separate patch (and another separate patch for malloc/free functions which was promised before).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85894/new/

https://reviews.llvm.org/D85894



More information about the llvm-commits mailing list