[PATCH] D86210: [llvm-reduce] Skip terminators when reducing instructions.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 23 09:55:39 PDT 2020


fhahn added a comment.

In D86210#2232204 <https://reviews.llvm.org/D86210#2232204>, @lebedev.ri wrote:

> Honestly i don't like this, mainly because this could result in valid reduction
> deleting *all* instructions, but then yes, it more frequently results in broken IR.
> So i think this will do after all. Thanks.

Thanks for taking a look! Happy to adjust things down the road if it turns out we are now missing any useful reductions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86210/new/

https://reviews.llvm.org/D86210



More information about the llvm-commits mailing list