[PATCH] D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat

Tyker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 22 12:08:42 PDT 2020


Tyker added a comment.

In D86404#2232128 <https://reviews.llvm.org/D86404#2232128>, @lebedev.ri wrote:

> Needs two tests - i agree that comdat makes sense, but i'm not sure about linkage.

maybe always setting it to external is not the correct decision here but some linkages like linkonce_odr are only valid on definitions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86404/new/

https://reviews.llvm.org/D86404



More information about the llvm-commits mailing list