[PATCH] D65471: [AMDGPU] Reserve all AGPRs on targets which do not have them

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 11:53:27 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/trunk/test/CodeGen/AMDGPU/spill-vgpr-to-agpr.ll:2
 ; RUN: llc -march=amdgcn -mcpu=gfx908 -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN,GFX908 %s
-; RUN: llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN,GFX900 %s
+; RUN: not llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s 2>&1 | FileCheck -check-prefixes=GCN,GFX900 %s
 
----------------
bjope wrote:
> What is the idea behind this test. This single RUN-line takes more than 50 seconds to run, just to discover a failure?
> 
> A little bit annoying when `llvm-lit test/CodeGen/AMDGPU/` only takes 11s when removing this particular RUN-line.
I just have tried it. This run took 4.5 seconds with the debug build. It is still fairly long, but nothing close to 50s.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65471/new/

https://reviews.llvm.org/D65471



More information about the llvm-commits mailing list