[PATCH] D86305: [DebugInfo][flang]Added support for representing Fortran assumed length strings

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 13:05:46 PDT 2020


schweitz added a comment.

In D86305#2230837 <https://reviews.llvm.org/D86305#2230837>, @SouraVX wrote:

> In D86305#2230794 <https://reviews.llvm.org/D86305#2230794>, @SouraVX wrote:
>
>> In D86305#2230724 <https://reviews.llvm.org/D86305#2230724>, @aprantl wrote:
>>
>>> I'm fine with whatever numbering makes your development the easiest. My only ask is that if we still have a gap after this, please document what nodes are expected to go there, so there 1) won't be any future conflicts and 2) we don't pointlessly reserve space.
>>
>> I'll have to re-confirm with our team. Making sure we don't break anything is priority for us.
>> @schweitz do you have any reservations WRT this ?
>
> We don't have any reservations with bit 42 and 43. If @schweitz also don't have any reservations we can mark/document them to be usable by others.

42 and 43 are being used on our branch to support Fortran array debugging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86305/new/

https://reviews.llvm.org/D86305



More information about the llvm-commits mailing list