[PATCH] D86275: [DSE,MemorySSA] Use BatchAA for AA queries.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 287054.
fhahn added a comment.

In D86275#2229617 <https://reviews.llvm.org/D86275#2229617>, @asbirlea wrote:

> The improvement looks great!

Yep, but just to note, this improvements is already included in the numbers shared on llvm-dev.

> The alias cache relies on MemoryLocations and should be valid. The nonEscaping cache relies on pointers, so here I had reservations on what happens if a store is in cache and gets removed. There are no future queries for it, and there are no new values in DSE that may reuse that pointer. So I *think* this is correct, but it needs some documentation in the pass on why BatchAA is ok to use here.
> I think it's necessary for the assumptions to be made clear in case the pass changes for some reason and breaks those assumptions; also if new caches are added in BatchAA, its users should have it clearly specified on what behavior they rely.

That makes sense! I added a comment to the BatchAA member in DSEState. Do you think that is sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86275/new/

https://reviews.llvm.org/D86275

Files:
  llvm/include/llvm/Analysis/AliasAnalysis.h
  llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86275.287054.patch
Type: text/x-patch
Size: 10164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200821/0e84044c/attachment.bin>