[PATCH] D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:451
+  SmallVector<Value *, 8> StoredValues; /// Mapped values.
+  SmallVector<StoreInst *, 8> LastAccesses;
+
----------------
Style: Avoid comments in the same line as code (always, except in calls like `,/* .. */ foo)` ). Put them before the declaration please.


================
Comment at: llvm/test/Transforms/OpenMP/values_in_offload_arrays.ll:3
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+ at .__omp_offloading_heavyComputation.region_id = weak constant i8 0
----------------
you need to require assertions (IIRC) otherwise this tests fails (as non-assert builds do not have debug print)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86300/new/

https://reviews.llvm.org/D86300