[PATCH] D85771: [DebugInstrRef][8/9] Convert DBG_INSTR_REFs into variable locations

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:923
   void defVar(const MachineInstr &MI, const MachineOperand &MO) {
     // XXX skipping overlapping fragments for now.
+    // Only DBG_VALUEs can define constant-valued variables.
----------------
aprantl wrote:
> ???
The overlapping fragments comment was a reminder to myself that I hadn't implemented support for it yet; I guess it isn't helpful being left in the code.

(It won't be forgotten in the future as there's a test for overlapping fragments in-tree already).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85771/new/

https://reviews.llvm.org/D85771