[PATCH] D86183: [DAGCombine] Remove dead node when it is created by getNegatedExpression

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 07:42:44 PDT 2020


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/CodeGen/X86/pr46877.ll:1
+; RUN: llc -O3 < %s -mcpu=haswell -mtriple=x86_64 > /dev/null 2>&1
+
----------------
I think if we are going to spend the time to execute a test, we might as well use FileCheck to verify the output asm. That way, we can detect if some future patch is doing something unexpected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86183/new/

https://reviews.llvm.org/D86183



More information about the llvm-commits mailing list