[PATCH] D86335: [RegisterPressure] Use Register instead of unsigned for RegUnit

[Jay Foad via Phabricator via llvm-commits]

foad abandoned this revision.
foad added a comment.

In D86335#2230402 <https://reviews.llvm.org/D86335#2230402>, @arsenm wrote:

> RegUnits are *not* registers, so you should not use Register for them

Fair enough. What are they?



================
Comment at: llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp:351
   for (const auto &RegMaskPair : RPTracker.getPressure().LiveInRegs) {
-    if (Register::isVirtualRegister(RegMaskPair.RegUnit))
       LiveInRegs.insert(RegMaskPair.RegUnit);
----------------
arsenm wrote:
> This query doesn't make any sense
Any idea what it should say instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86335/new/

https://reviews.llvm.org/D86335