[PATCH] D86337: Remove raw_sha1_ostream

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 03:02:35 PDT 2020


teemperor created this revision.
teemperor added reviewers: mehdi_amini, davide.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.
teemperor requested review of this revision.

raw_sha1_ostream was added as in 2016 as part of D16325 <https://reviews.llvm.org/D16325> and the SHA1 implementation from that patch
has since then been used by a few other parts of LLVM. However, the raw_sha1_ostream class that
was also introduced by D16325 <https://reviews.llvm.org/D16325> has no active users anywhere in LLVM.

The code itself looks perfectly fine, but as it's unused it doesn't seem worthwhile to make everyone
compile, maintain and run the tests for this class.


https://reviews.llvm.org/D86337

Files:
  llvm/include/llvm/Support/raw_sha1_ostream.h
  llvm/unittests/Support/CMakeLists.txt
  llvm/unittests/Support/raw_sha1_ostream_test.cpp
  llvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86337.286982.patch
Type: text/x-patch
Size: 5470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200821/2f06e3cd/attachment.bin>


More information about the llvm-commits mailing list