[PATCH] D86270: [AMDGPU] Use tablegen for argument indices

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:698
+  int RsrcArgIndex = !add(NumDataArgs, NumDmaskArgs, NumVAddrArgs);
+  int SampArgIndex = !add(NumDataArgs, NumDmaskArgs, NumVAddrArgs, NumRSrcArgs);
   int UnormArgIndex = !add(NumDataArgs, NumDmaskArgs, NumVAddrArgs, NumRSrcArgs, 1);
----------------
Would it make more sense to daisy-chain these so e.g. SampArgIndex is just !add(RSrcArgIndex, NumRSrcArgs)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86270/new/

https://reviews.llvm.org/D86270