[PATCH] D86208: [llvm-readelf] - Start recognizing 'PT_OPENBSD_*' segment types.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 00:18:56 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

On the basis that this makes the code simpler, and there's no strong motivation not to do this, LGTM.

We might want to consider a strategy for better deciding when to interpret these and other OS-specific segment types however, since not all OSes will support them, and in the worst case, there could even be duplicate meanings for a given value. The alternative to supporting them would be to remove them from the program header definition, of course.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86208/new/

https://reviews.llvm.org/D86208



More information about the llvm-commits mailing list