[PATCH] D86170: PrintStackTrace: don't symbolize if LLVM_DISABLE_SYMBOLIZATION is set

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/tools/not/disable-symbolization.test:1
+# RUN: not --crash env > %t || true
+# RUN: FileCheck %s < %t
----------------
MaskRay wrote:
> aganea wrote:
> > This test also fails on Windows - I think lit doesn't like `env` alone.
> > 
> > ```
> > ******************** TEST 'LLVM :: tools/not/disable-symbolization.test' FAILED ********************
> > Script:
> > --
> > : 'RUN: at line 1';   not --crash env > D:\llvm-project\buildninjaRel\test\tools\not\Output\disable-symbolization.test.tmp || true
> > : 'RUN: at line 2';   d:\llvm-project\buildninjarel\bin\filecheck.exe D:\llvm-project\llvm\test\tools\not\disable-symbolization.test < D:\llvm-project\buildninjaRel\test\tools\not\Output\disable-symbolization.test.tmp
> > --
> > Exit Code: 127
> > 
> > Command Output (stdout):
> > --
> > $ ":" "RUN: at line 1"
> > $ "not" "--crash" "env"
> > # command stderr:
> > Error: 'env' requires a subcommand
> > error: command failed with exit status: 127
> > 
> > --
> > ```
> > 
> > `printenv` instead?
> Thanks! `printenv` is not specified by POSIX, so I did not use it. But I just checked: `printenv` appeared in 3.0BSD & Solaris has it as well, so the portability is good.
Any ideas if this'll work on Windows?


================
Comment at: llvm/utils/not/not.cpp:37-43
+#ifdef _WIN32
+    SetEnvironmentVariableA("LLVM_DISABLE_CRASH_REPORT", "1");
+    SetEnvironmentVariableA("LLVM_DISABLE_SYMBOLIZATION", "1");
+#else
+    setenv("LLVM_DISABLE_CRASH_REPORT", "1", 0);
+    setenv("LLVM_DISABLE_SYMBOLIZATION", "1", 0);
+#endif
----------------
Rather than adding non-portable code, any chance of passing this environment variable into the child process creation in ExecuteAndWait?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86170/new/

https://reviews.llvm.org/D86170