[PATCH] D86305: [DebugInfo]Added support for representing Fortran assumed length strings

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:852
+                    (Tag, Name, StringLength, StringLengthExp, SizeInBits,
+                     AlignInBits, Encoding))
+
----------------
SouraVX wrote:
> aprantl wrote:
> > Are these copy&paste errors?
> Nope, just for backward compatilbility I guess ? just like other nodes. Notice one expects `MDString` and other one `StringRef`
I see. But since this is a new node, we don't need all the variants with the default arguments, do we? I think I'd be more comfortable with the minimal set we can get away with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86305/new/

https://reviews.llvm.org/D86305