[PATCH] D86312: [X86] Copy the tuning features and scheduler model from pentium4/x86-64 to generic

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 12:21:05 PDT 2020


craig.topper created this revision.
craig.topper added reviewers: RKSimon, andreadb, spatel, echristo, efriedma.
Herald added subscribers: jfb, gbedwell, hiraditya.
Herald added a project: LLVM.
craig.topper requested review of this revision.

This is preparation for making clang default to -mtune=generic when no -march is specified. This will allow the default tuning to be "generic" even though our default march is "pentium4" or "x86-64".

To avoid llc lit test regressions, if no mcpu is specified, I've defaulted tune to use i586 to match the old tuning settings of no CPU. Some tests explicitly used -mcpu=generic which I've removed so they instead get this default of architecture features from generic and tune from i586.

I updated one llvm-mca test to check a different CPU since generic has a scheduler model now


https://reviews.llvm.org/D86312

Files:
  llvm/lib/Target/X86/X86.td
  llvm/lib/Target/X86/X86Subtarget.cpp
  llvm/test/CodeGen/X86/2007-11-06-InstrSched.ll
  llvm/test/CodeGen/X86/abi-isel.ll
  llvm/test/CodeGen/X86/add.ll
  llvm/test/CodeGen/X86/full-lsr.ll
  llvm/test/CodeGen/X86/lsr-loop-exit-cond.ll
  llvm/test/CodeGen/X86/lsr-static-addr.ll
  llvm/test/CodeGen/X86/masked-iv-safe.ll
  llvm/test/CodeGen/X86/optimize-max-3.ll
  llvm/test/CodeGen/X86/select.ll
  llvm/test/CodeGen/X86/vec_call.ll
  llvm/test/CodeGen/X86/vec_setcc-2.ll
  llvm/test/CodeGen/X86/widen_cast-1.ll
  llvm/test/tools/llvm-mca/X86/no-sched-model.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86312.286872.patch
Type: text/x-patch
Size: 13156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200820/db3113d9/attachment.bin>


More information about the llvm-commits mailing list