[PATCH] D86147: [LangRef] Revise semantics of get.active.lane.mask

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 11:08:13 PDT 2020


SjoerdMeijer added a comment.

I have removed the WIP tag because I think this is behaving as expected in the patches that I adapted to this new behaviour (D86304 <https://reviews.llvm.org/D86304>, D86302 <https://reviews.llvm.org/D86302>, D86301 <https://reviews.llvm.org/D86301>, and D86303 <https://reviews.llvm.org/D86303>).

>>   icmp ule (%base + i), %n - 1
>
> How about icmp ult (%base + i), %n?

I have kept the `%n - 1` for now, because it makes a bit more explicit here that we pass in the tripcount with `%n`, but that that the comparison is done with the backedge-taken count `%n-1`.
But in the le D86302galizer patch  D86302 <https://reviews.llvm.org/D86302>, I do expand it to: `icmp ult (%base + i), %n`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86147/new/

https://reviews.llvm.org/D86147



More information about the llvm-commits mailing list