[PATCH] D86309: [ELF] Handle SHT_RISCV_ATTRIBUTES similarly to SHT_ARM_ATTRIBUTES

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 10:42:23 PDT 2020


jrtc27 added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:871
-    if (config->emachine != EM_ARM)
-      break;
     ARMAttributeParser attributes;
----------------
NB: There is no default case for the switch statement so hoisting these out (required since `SHT_ARM_ATTRIBUTES` and `SHT_RISCV_ATTRIBUTES` use the same encoding in the arch-specific range) and thus losing the ability to break to the end of the switch shouldn't be a change of behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86309/new/

https://reviews.llvm.org/D86309



More information about the llvm-commits mailing list