[PATCH] D86249: [llvm][sve] Make `llvm.masked.[gather|scatter]` legal for SVE.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 09:15:23 PDT 2020


fpetrogalli added a comment.

In D86249#2227281 <https://reviews.llvm.org/D86249#2227281>, @efriedma wrote:

> ScalarizeMaskedMemIntrin can't scalarize scalable vectors on any target; would it make sense to check there?

Sure, good idea, working on it. It is a trivial change, but I would like to add a comment as an explanation. What is the reason for not being able to scalarize anything that work on scalable vectors? Is it because this scalarization pass cannot (shouldn't?) produce loops?

> We probably want the TTI change eventually for the sake of cost modeling in the vectorizer, but I'd prefer to be defensive about inappropriate transforms on scalable vectors.

OK - but I think I should remove them from this patch. We will introduce them when needed. Does that sound right to you?

Thank you!

Francesco


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86249/new/

https://reviews.llvm.org/D86249



More information about the llvm-commits mailing list