[PATCH] D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass

Anh Tuyen Tran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 06:51:29 PDT 2020


anhtuyen added a comment.

In D86262#2228123 <https://reviews.llvm.org/D86262#2228123>, @nemanjai wrote:

> Presumably (now or in the future) there may be other places in this pass that produce memset/memcpy. Also, we will unnecessarily collect stores in in `collectStores()`. So it seems to me like it might be more advantageous to have these options prevent `isLegalStore()` from returning the corresponding store type.

I agree with your observation.  I will change the location (if we end up with disabling memset/memcpy).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86262/new/

https://reviews.llvm.org/D86262



More information about the llvm-commits mailing list