[PATCH] D81667: [FileCheck] Add precision to format specifier

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:754-757
+    ; CHECK: mov r[[#REG:]], 0x[[#%.8X,ADDR:]]
 
-would match ``mov r5, 0xF0F0`` and set ``REG`` to the value ``5`` and ``IMM``
-to the value ``0xF0F0``.
+would match ``mov r5, 0xF0F0FEFE`` and set ``REG`` to the value ``5`` and
+``ADDR`` to the value ``0xF0F0FEFE``.
----------------
jhenderson wrote:
> If this example is meant to demonstrate the precision as well as conversion, it probably makes sense to say something like "but would not match `mov r5, 0x00F0F0FEFE`" and/or change the example to `mov r5, 0x0000F0F0`, so that it shows the precision behaviour.
Good point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81667/new/

https://reviews.llvm.org/D81667