[PATCH] D86268: [DAGTypeLegalizer] Handle ZERO_EXTEND of promoted integer in WidenVecRes_Convert.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 01:19:34 PDT 2020


jonpa added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3317
+      Opcode = ISD::TRUNCATE;
+  }
+
----------------
Does this assume that the final (unroll) part of the method will always be reached? In that case, should that be made explicit with an extra "else" wrapping the cases for Widening/Legal, and alsomaybe  an assert that the promoted  InVT does then not need Widening or is legal?




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86268/new/

https://reviews.llvm.org/D86268



More information about the llvm-commits mailing list