[PATCH] D86190: [LICM][Coroutine] Don't sink stores from loops with coro.suspend instructions.

[JunMa via Phabricator via llvm-commits]

junparser added a comment.

In D86190#2227340 <https://reviews.llvm.org/D86190#2227340>, @efriedma wrote:

> Are you sure this is the right fix?  At first glance, ensuring %p lives long enough seems like the sort of thing coroutine lowering should be able to deal with.  If it isn't, at the very least we need documentation describing what optimizations are legal.

I just disable promotion before coroutine lowering and count on promotion after lowering which might not be the right fix.  @lxfind's comment seems to be the right solution.  Need some investigation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86190/new/

https://reviews.llvm.org/D86190