[PATCH] D86045: [llvm-dwarfdump] --statistics: switch to json::OStream. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 15:23:31 PDT 2020


MaskRay added a comment.

In D86045#2227240 <https://reviews.llvm.org/D86045#2227240>, @echristo wrote:

> I feel pretty OK approving this.
>
> (Tradeoffs I'd contemplated and discarded was renaming OS rather than OS->J everywhere. I ended up liking the readability of J more. JS might be nice as well?)
>
> -eric

Do you mean removing the OS->J rename? That would be a bit ambiguous because people usually use `OS` to refer to raw_ostream and its derivatives. The JSON stream is special.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86045/new/

https://reviews.llvm.org/D86045



More information about the llvm-commits mailing list