[PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

Wed Aug 19 11:21:14 PDT 2020

dblaikie added a comment.

In D86110#2225970 <https://reviews.llvm.org/D86110#2225970>, @labath wrote:

> In D86110#2224163 <https://reviews.llvm.org/D86110#2224163>, @dblaikie wrote:
>
>> In D86110#2223905 <https://reviews.llvm.org/D86110#2223905>, @labath wrote:
>>
>>> This sounds perfectly reasonable to me. The offsets are present in memory already so there's no point in storing them in a vector as well.
>>
>> Thanks for taking a look! I'll take this as approval and commit soon.
>
> The patch had a WIP label, so I was only looking/commenting on the high-level idea. But after looking at the implementation more closely, I think that looks good too.

Right right - sorry about that. Realized after I committed it it still had that tag & totally understand it gave the wrong impression. I think when I wrote the commit message I was still thinking about it, but by the time I sent it for review, tested more things, etc, I was more comfortable with it & didn't think to change the message.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86110/new/

https://reviews.llvm.org/D86110