[PATCH] D83047: [LiveDebugValues] 2/4 Add instruction-referencing LiveDebugValues implementation

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

In D83047#2223992 <https://reviews.llvm.org/D83047#2223992>, @jmorse wrote:

> In D83047#2208102 <https://reviews.llvm.org/D83047#2208102>, @vsk wrote:
>
>> Hi @jmorse, thanks for the updates on the DbgValue::{Proposed,NoVal} scheme.
>>
>> I'm having trouble paging in enough of the DBG_INSTR_REF patch queue to continue giving meaningful review. I'm not sure the traditional review process is a great fit for this, since the changes are at a prototype stage. Perhaps we might be better served by landing things as they are, as a separate code path guarded behind a cl::opt? This would allow more people to test and contribute patches. Wdyt? (cc @aprantl @davide)
>
> Ping @aprantl regarding this ^^^.
>
> To avoid vagueness: it'd be great if this could be landed as a prototype and then refined / built up from there.

Since I'm also dealing with some cognitive overload at the moment, I'm pragmatically going to agree!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83047/new/

https://reviews.llvm.org/D83047