[PATCH] D85225: [Target][AArch64] Allow for char as int8_t in AArch64AsmParser.cpp

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D85225#2223849 <https://reviews.llvm.org/D85225#2223849>, @paulwalker-arm wrote:

> I have no real objections to this patch other than I prefer:
>
>   bool IsByte = std::is_same<int8_t, std::make_signed_t<T>>::value ||
>                 std::is_same<int8_t, T>::value;
>
> if that works for your use case, if not then I'm happy with your current solution.  Please can you give others a day or so longer to intervene in case they have a better suggestion.

I've now tested that variant, too, as before: works just as well.

I'm fine with either solution (although I prefer the `sizeof` one since it's way shorter/easier to read).

Just let me know when you've reached consensus.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85225/new/

https://reviews.llvm.org/D85225