[PATCH] D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause

[Irina Dobrescu via Phabricator via llvm-commits]

Rin marked 3 inline comments as done.
Rin added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:108
   SymbolSet dataSharingAttributeObjects_; // on one directive
+  SymbolSet privateDataSharingAttributeObjects_;
   SemanticsContext &context_;
----------------
I should clear this set after each directive. I'll add this in the next update


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:884
+      context_.Say(name.source,
+        "The ALLOCATE clause requires that '%s' must appear in a data-sharing "
+        "attribute clause on the same directive"_err_en_US,
----------------
Here it was meant to be "private data-sharing attribute clause". I'll change that in the next update. I'll fix formatting issue in that update also


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86051/new/

https://reviews.llvm.org/D86051