[PATCH] D85741: [DebugInstrRef][1/9] Initial fields and instruction for instruction-referencing variable locations

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 08:36:59 PDT 2020


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Mechanically this looks fine — would be good for others to chime in whether we have consensus over doing this change though.



================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:138
+    : MCID(&MI.getDesc()), Info(MI.Info), debugLoc(MI.getDebugLoc()),
+      DebugInstrNum(0) {
   assert(debugLoc.hasTrivialDestructor() && "Expected trivial destructor");
----------------
Use `= 0` in the header instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85741/new/

https://reviews.llvm.org/D85741



More information about the llvm-commits mailing list