[llvm] 92bcd24 - [InstCombine] update stale comments in test files; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 19 04:42:13 PDT 2020


Author: Sanjay Patel
Date: 2020-08-19T07:42:06-04:00
New Revision: 92bcd240f2565a79f94e0e9ac926b9135f03cbd6

URL: https://github.com/llvm/llvm-project/commit/92bcd240f2565a79f94e0e9ac926b9135f03cbd6
DIFF: https://github.com/llvm/llvm-project/commit/92bcd240f2565a79f94e0e9ac926b9135f03cbd6.diff

LOG: [InstCombine] update stale comments in test files; NFC

I missed updating these with:
rG23bd33c6acc4

Added: 
    

Modified: 
    llvm/test/Transforms/InstCombine/and-xor-or.ll
    llvm/test/Transforms/InstCombine/xor.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/and-xor-or.ll b/llvm/test/Transforms/InstCombine/and-xor-or.ll
index 7df0591a8fa9..6e54c5318d21 100644
--- a/llvm/test/Transforms/InstCombine/and-xor-or.ll
+++ b/llvm/test/Transforms/InstCombine/and-xor-or.ll
@@ -70,7 +70,7 @@ define <2 x i32> @and_xor_common_op_commute3(<2 x i32> %pa, <2 x i32> %pb) {
 }
 
 ; It's ok to match a common constant.
-; TODO: The xor should be a 'not' op (-1 constant), but demanded bits shrinks it.
+; The xor should be a 'not' op (-1 constant).
 
 define <4 x i32> @and_xor_common_op_constant(<4 x i32> %A) {
 ; CHECK-LABEL: @and_xor_common_op_constant(

diff  --git a/llvm/test/Transforms/InstCombine/xor.ll b/llvm/test/Transforms/InstCombine/xor.ll
index 3038f53bbd20..c67a33dbd401 100644
--- a/llvm/test/Transforms/InstCombine/xor.ll
+++ b/llvm/test/Transforms/InstCombine/xor.ll
@@ -996,7 +996,7 @@ define i4 @or_or_xor_use2(i4 %x, i4 %y, i4 %z, i4* %p) {
 }
 
 ; PR32706 - https://bugs.llvm.org/show_bug.cgi?id=32706
-; TODO: Pin an xor constant operand to -1 if possible because 'not' is better for SCEV and codegen.
+; Pin an xor constant operand to -1 if possible because 'not' is better for SCEV and codegen.
 
 define i32 @not_is_canonical(i32 %x, i32 %y) {
 ; CHECK-LABEL: @not_is_canonical(


        


More information about the llvm-commits mailing list