[PATCH] D86141: [GlobalISel][IRTranslator] Support PHI instructions in landingpad blocks

[Konstantin Schwarz via Phabricator via llvm-commits]

kschwarz added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2032
 
   // FIXME: support Windows exception handling.
+  if (!isa<LandingPadInst>(EHPadBB->getFirstNonPHI()))
----------------
arsenm wrote:
> Is the fixme still relevant?
I think so. Windows uses catchswitch/catchpad instructions for exception handling AFAIK, which aren't handled yet.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-exceptions.ll:128
+  ret i32 %r.0
+}
----------------
arsenm wrote:
> Is it legal to have debug info before the landing pad? If so can you add a test with that in the way too?
Seems its not legal. From LangRef:
> [...] ‘exception’ label is required to have the “landingpad” instruction, which contains the information about the behavior of the program after unwinding happens, as its first non-PHI instruction.

 





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86141/new/

https://reviews.llvm.org/D86141