[PATCH] D86168: [DFSan] Handle mmap() calls before interceptors are installed.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 19:04:29 PDT 2020


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/dfsan/dfsan_interceptors.cpp:23
 
+static bool interceptors_initialized;
+
----------------
Have you considered EnsureInterceptorsInitialized from compiler-rt/lib/cfi/cfi.cpp or compiler-rt/lib/safestack/safestack.cpp
I suspect it should not work as you can't do INTERCEPT_FUNCTION here

Anyway as is it's a data race, some synchronization is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86168/new/

https://reviews.llvm.org/D86168



More information about the llvm-commits mailing list