[PATCH] D85404: [lld-macho] Handle TAPI and regular re-exports uniformly

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:354-355
     if (auto *dylibFile = dyn_cast<DylibFile>(file)) {
-      StringRef filename = path::filename(dylibFile->getName());
-      if (filename.consume_front(searchName) && filename == ".dylib") {
+      StringRef name = path::filename(dylibFile->dylibName);
+      if (name.consume_front(searchName) && name == ".dylib") {
         dylibFile->reexport = true;
----------------
int3 wrote:
> smeenai wrote:
> > Can we get a test for this fix as well? (It should also probably be its own diff.)
> whoops, I did not mean to leave this change in at all. It isn't a fix, it's wrong :p 
my bad, a fix for this is actually necessary. Initial attempt was wrong though x:

real fix here: D86180


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85404/new/

https://reviews.llvm.org/D85404