[PATCH] D86071: [MLIR][OpenMP] Add omp.do operation

Tue Aug 18 14:15:45 PDT 2020

kiranchandramohan added inline comments.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:120
+
+// static and auto are C++ keywords so need a _ to disambiguate
+def OMP_SCHEDULE_static_ : ClauseVal<"static_",2,1> {}
----------------
clementval wrote:
> kiranchandramohan wrote:
> > For the default clause in parallel we have used a prefix "def" to fix this issue. I think we need to standardize this. Would converting the first letter to caps be a reasonable workaround since reserved keywords do not have a letter with caps as first letter?
> That's probably a good idea to have a standard way to do that. +1 for the first letter capitalized if it works. 
I have filed an issue https://bugs.llvm.org/show_bug.cgi?id=47225 regarding StrEnumAttr not accepting reserved C++ keywords.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071