[PATCH] D86166: sanitizer_common: Use void* for madvise first argument on Solaris.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 13:16:00 PDT 2020


pcc added a comment.

@ro On D85870 <https://reviews.llvm.org/D85870> you mentioned that the declaration has been changed in Solaris 11.4 to use `void *` which causes a build break on 11.4 due to the incompatible declaration. I checked illumos and it looks like their declaration still has `caddr_t`, although the comment above this declaration implies that that shouldn't matter because the system's declaration isn't visible. But what about older versions of Solaris? Presumably they still have a declaration with `caddr_t` so I imagine the build would break with an incompatible declaration error there. Or do we not care about older versions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86166/new/

https://reviews.llvm.org/D86166



More information about the llvm-commits mailing list