[PATCH] D86128: [Attributor][NFC] Add tests to range.ll

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 12:22:51 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/Transforms/Attributor/range.ll:1766
+  ret i32 99
+}
+
----------------
okura wrote:
> jdoerfert wrote:
> > What is the difference to `less_than_100_1`?
> (`less_than_100` | `is_less_than_100`) _1 and _2 are the same (respectively). I duplicate them because I want to split `propagate_range1` and `propagate_range2` completely.  
> When I handle `CallBase` in `AAValueConstantRange::initialize`, the value will be simplified in the former case and will not in the latter case. However, If we use the same `less_than_100` and `is_less_than_100` in both tests, the value will be simplified in both cases.
makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86128/new/

https://reviews.llvm.org/D86128



More information about the llvm-commits mailing list