[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 11:52:02 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CGPassBuilderOption.h:41-43
+  bool DisableLSR = false;
+  bool DisableCGP = false;
+  bool PrintLSR = false;
----------------
ychen wrote:
> arsenm wrote:
> > I think these need longer names and documentation comments
> Sounds great. Comments added. I could do a followup patch for longer names. My intention was to make this close to a pure porting patch. WYDT? I don't mind put the renaming here though because they should be straightforward.
It's not like it's sharing the actual code, so might as well improve over the old system


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608



More information about the llvm-commits mailing list